search

hpi-swa / smalltalkCI

Framework for testing Smalltalk projects with GitHub Actions, GitLab CI, Travis CI, AppVeyor, and others.
MIT License
96 stars 68 forks source link

Fix invocation of image/VM with spaces in path #543

Closed LinqLover closed 2 years ago

LinqLover commented 2 years ago

Without this patch, it is not possible to pass a VM path containing spaces to smalltalkCI, like here in mingw:

$ smalltalkci -s Squeak64-Trunk --vm "/c/Program Files (x86)/Squeak/SqueakConsole.exe"

Analogously, you previously could not pass an image path containing spaces like

$ smalltalkci -s Squeak64-Trunk --image "/path/to/My Squeak.image"

For more information, see: https://github.com/koalaman/shellcheck/wiki/SC2124

LinqLover commented 2 years ago

By the way, there are loads of other warnings caused by shellcheck in all the script files in this repository. It would probably not harm to address them at some later point in time as well. 😅

fniephaus commented 2 years ago

By the way, there are loads of other warnings caused by shellcheck in all the script files in this repository. It would probably not harm to address them at some later point in time as well.

Yeah, I agree. Would be nice to add a shellcheck build job at some point.

fniephaus commented 2 years ago

Integrated as part of #575.