search

hpi-swa / smalltalkCI

Framework for testing Smalltalk projects with GitHub Actions, GitLab CI, Travis CI, AppVeyor, and others.
MIT License
94 stars 68 forks source link

Image closes when using ‘--headful’ with ‘Pharo64-9.0’ #561

Closed Rinzwind closed 1 year ago

Rinzwind commented 2 years ago

When using ‘Pharo64-9.0’ with option ‘--headful’, the image doesn’t stay open as expected:

./bin/smalltalkci --headful --smalltalk Pharo64-9.0

It does stay open when using ‘Pharo64-8.0’:

./bin/smalltalkci --headful --smalltalk Pharo64-8.0

The following outputs ‘isHeadless: true’ for the Pharo 9 build, and ‘isHeadless: false’ for the Pharo 8 build:

for b in _builds/*; do (cd "$b"; ./vm TravisCI.image eval "Stdio stdout nextPutAll: 'isHeadless: ' , SmalltalkCI isHeadless asString; lf. Smalltalk snapshot: false andQuit: true"); done
fniephaus commented 2 years ago

isHeadless uses Smalltalk isHeadless in Pharo. Not sure what is happening here and what has changed. @estebanlm?

Rinzwind commented 2 years ago

Seems related to this: https://github.com/pharo-project/pharo/issues/10727

Rinzwind commented 1 year ago

Just a note: to avoid this issue, we’ve patched smalltalk-CI with an extra method SmalltalkCIPharo9 class>>#isHeadless implemented as returning the value of Smalltalk isInteractiveGraphic not.

fniephaus commented 1 year ago

Thanks for the update, @Rinzwind. Please feel free to contribute the patch and add it to one of the Pharo-specific classes.

jvalteren commented 1 year ago

@Rinzwind Thanks for the suggestion. I've committed it to our fork of the repo. Are you planning to create a pull request or shall I?

Rinzwind commented 1 year ago

Forgot about this, sorry, please do create the pull request.

jvalteren commented 1 year ago

Hi @Rinzwind, this is now resolved as per your suggested change to SmalltalkCIPharo9, thanks! Also thank you @fniephaus for accepting the PR so quickly!