hpi-swa / smalltalkCI

Framework for testing Smalltalk projects with GitHub Actions, GitLab CI, Travis CI, AppVeyor, and others.
MIT License
94 stars 68 forks source link

Fix handling of traits for coverage testing #572

Open LinqLover opened 1 year ago

LinqLover commented 1 year ago

The implementation mostly follows the design of SUnit coverage for traits.2.cs[^1], this implementation for smalltalkCI also makes the following changes:

Also updates the relevant documentation.

To try it out, you can follow the steps from here.

Follow-up of #571. Complements SUnit coverage for traits.2.cs for Squeak and depends on Traits-eventualUsers.3.cs. The dependency is non-technical, i.e., this PR is written without introducing a hard dependency on Traits, but no change in behavior will reveal before the changeset is merged into the Traits package, and I believe it's a better idea to wait for potential feedback on that patch before merging this PR.

[^1]: [squeak-dev] Review Request: TestCoverage-traits.1.cs

fniephaus commented 1 year ago

Is this ready for review?

fniephaus commented 1 year ago

After integrating #571, there are now some merge conflicts. Would be great if you could address them. Thanks!

LinqLover commented 1 year ago

This one is not yet ready. :-) It depends on SUnit coverage for traits.2.cs for Traits which is not yet merged but I still need to apply some feedback and then update this PR. I will ping you again when it is ready for review ...