hpi-swa / smalltalkCI

Framework for testing Smalltalk projects with GitHub Actions, GitLab CI, Travis CI, AppVeyor, and others.
MIT License
94 stars 68 forks source link

[improvement] add Iceberg registering for the loaded project #579

Closed hogoww closed 1 year ago

hogoww commented 1 year ago

This fixes the issue #552 I opened a while back. Let me know if I have to do more :)

Pierre

fniephaus commented 1 year ago

Thanks, @hogoww. Could you please remove all unrelated metadata changes so we can better see what has actually changed?

So far, I've only seen SmalltalkCI.class/instance/load.st, which is unfortunately in the generic SmalltalkCI class. I'd assume this only works in Pharo so it should probably be moved to one of the classes in the SmalltalkCI-Pharo-Core.package, for example SmalltalkCIPharo11? Maybe @estebanlm has an opinion on that?

hogoww commented 1 year ago

Oh my. I was clearly not well woken up when I did this. Sorry, I'll redo it properly a bit later :D Thanks @fniephaus !

Pierre