Fix for #585 (Code coverage in Pharo is unexpectedly wrapping all methods of a class that is extended by a package under test)

hpi-swa / smalltalkCI

Framework for testing Smalltalk projects with GitHub Actions, GitLab CI, Travis CI, AppVeyor, and others.

MIT License

94 stars 68 forks source link

Fix for #585 (Code coverage in Pharo is unexpectedly wrapping all methods of a class that is extended by a package under test) #586

Closed jbrichau closed 1 year ago

jbrichau commented 1 year ago

Only consider entire classes defined in a package when retrieving classesInPackage. This fixes https://github.com/hpi-swa/smalltalkCI/issues/585.

Using these modifications, the Grease build works using coverage: https://github.com/SeasideSt/Grease/actions/runs/3981443794

Before, it used to become unresponsive and timeout: https://github.com/SeasideSt/Grease/actions/runs/3980634960

jbrichau commented 1 year ago

I noticed that committing the entire project via Iceberg modifies and breaks stuff, so I reverted the commit and only selected the necessary method change. If the change is accepted, I would recommend doing a squash commit for the PR