update GemStone builds to run on Ubuntu 20.04 and macos-latest

[dalehenrich]

As of this dalehenrich/smalltalkCI build, I've got the GemStone builds to pass for 20.04 and moacos, however, when I add the full pharo/squeakmosse lineup I'm seeing /d/a/smalltalkCI/smalltalkCI/helpers.sh: line 558: config_smalltalk: unbound variable ERROS and it is not obvious to me how to fix this issue ... I ran into the issue in GemStone builds and fixed it by using the following :

-  if [[ "${config_tracking}" != "true" ]]; then
-    return 0
+  if [ "${config_tracking+set}" ] then
+   if [[ "${config_tracking}" != "true" ]]; then
+       return 0
+ fi

but the solution is not as obvious on line 558:

  curl -s --header "X-BUILD-DURATION: ${duration}" \
          --header "X-BUILD-ENV: ${env_name}" \
          --header "X-BUILD-SMALLTALK: ${config_smalltalk}" \
          --header "X-BUILD-STATUS: ${build_status}" \
            "https://smalltalkci.fniephaus.com/api/" > /dev/null || true

Some guidance in this area would be appreciated.

[fniephaus]

Hi Dale, good question... I didn't see anything obviously wrong (apart from that you seem to be mixing branches). All of these vars should be defined when coverage is supposed to be reported. I can take a closer look in the next few days if you don't work out what's wrong.

[fniephaus]

Oh, maybe it's because you're pushing your commits to your fork and for that, you don't have coveralls enabled? Yes, the build shouldn't fail neither because of that nor because it can't do the tracking thing. To confirm my suspicion, maybe push your branch to this repo?

[dalehenrich]

Thanks! Will do ...

[dalehenrich]

reproduced the failure on local issue_591 branch

[fniephaus]

I think I've fixed this with https://github.com/hpi-swa/smalltalkCI/commit/a84db3fce21126997392a9be2fe6cbae91c166a0. There seems to be a problem with the Windows VMs, which leads to corrupted JSON files, which then fail to be uploaded with curl to coveralls, which fails the subshell, which does not have access to config_smalltalk etc.

[dalehenrich]

... merged changes ... but GToolKit looks to be segfaulting on mac? ... will restart without GToolKist and try to get a GemStone run ...

[dalehenrich]

ended up commenting out GToolKit and the GemStone builds are now passing ... looks like you are already working on the GToolKit issue, so I'll merge when done and submit PR ... Thanks for your help!

[dalehenrich]

A different kind of GToolKit failure after merging to master to pick up your changes. Previous commit ran clean with GToolKit commented out.

[fniephaus]

Feel free to open a PR now. We probably need to mark the GToolkit builds as allowed failures if they are too flaky.