search

hpi-swa / smalltalkCI

Framework for testing Smalltalk projects with GitHub Actions, GitLab CI, Travis CI, AppVeyor, and others.
MIT License
94 stars 68 forks source link

Enable Pharo 12 #596

Closed jecisc closed 1 year ago

jecisc commented 1 year ago

This PR enable Pharo 12 in smalltalk CI

jecisc commented 1 year ago

This time it seens to be good :)

gcotelli commented 1 year ago

Then just go ahead. The other changes looks good to me

On Tue, Apr 18, 2023, 03:08 Fabio Niephaus @.***> wrote:

@.**** commented on this pull request.

In repository/SmalltalkCI-Pharo-Coverage-Core.package/SCIPharoCodeCoverage.class/class/packageNameForMethod..st https://github.com/hpi-swa/smalltalkCI/pull/596#discussion_r1169535387:

  • | aClass |
  • aClass := aMethodReference compiledMethod methodClass.
  • ^ (aClass packages detect: [:each | each includesSelector: aMethodReference compiledMethod selector ofClass: aClass ]) packageName

The Pharo32-3.0 build seems to work: https://github.com/hpi-swa/smalltalkCI/actions/runs/4721085924/jobs/8373939180?pr=596#step:4:271

Is this good to go, @gcotelli https://github.com/gcotelli?

— Reply to this email directly, view it on GitHub https://github.com/hpi-swa/smalltalkCI/pull/596#discussion_r1169535387, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAQCK6CKLOMCC5RLGS5SEELXBYVUBANCNFSM6AAAAAAXBCI4BU . You are receiving this because you were mentioned.Message ID: @.***>