Fix bug in ‘pharo::prepare_image’ which always downloads the image again

hpi-swa / smalltalkCI

Framework for testing Smalltalk projects with GitHub Actions, GitLab CI, Travis CI, AppVeyor, and others.

MIT License

94 stars 68 forks source link

Fix bug in ‘pharo::prepare_image’ which always downloads the image again #604

Closed Rinzwind closed 1 year ago

Rinzwind commented 1 year ago

This pull request fixes a bug in ‘pharo::prepare_image’ where the image was always downloaded again due to ‘is_file’ being used instead of ‘is_dir’ to test the existence of the ‘target’ directory.

The bug seems to have been introduced in commit 3018a631f2a5839d, the test previously checked the existence of the image file instead of the directory.