search

hpi-swa / smalltalkCI

Framework for testing Smalltalk projects with GitHub Actions, GitLab CI, Travis CI, AppVeyor, and others.
MIT License
94 stars 68 forks source link

adjusted saveImage for Pharo11 as it returns a SnapshotOperation instead #634

Closed noha closed 6 months ago

noha commented 6 months ago

of boolean

Fixes #631

labordep commented 6 months ago

Thanks for the fix! Looks good for Pharo 11👌

fniephaus commented 6 months ago

Thanks for confirming, @labordep!

labordep commented 6 months ago

@fniephaus I cannot see any changes for Pharo 12 CI (always the same issue), is it normal? Edit: My bad, it seems to be another issue :)

fniephaus commented 6 months ago

The Pharo 12 compatibility class inherits from the one for Pharo 11, so this fix should apply to Pharo 11 and 12.

labordep commented 6 months ago

Ok, this is another issue, I will open it.