hpi-swa / smalltalkCI

Framework for testing Smalltalk projects with GitHub Actions, GitLab CI, Travis CI, AppVeyor, and others.
MIT License
94 stars 68 forks source link

Create allPackageNames.st #644

Closed Ducasse closed 2 months ago

Ducasse commented 2 months ago

RPackageOrganizer was deprecated in Pharo12 and removed in Pharo13

Ducasse commented 2 months ago

@jecisc

fniephaus commented 2 months ago

Thanks for the PR! Unfortunately, the Pharo64-13 check is failing with:

KeyNotFound: key #RPackageOrganizer not found in SystemDictionary
SystemDictionary(Dictionary)>>errorKeyNotFound:
[self errorKeyNotFound: key] in SystemDictionary(Dictionary)>>at: in Block: [self errorKeyNotFound: key]
SystemDictionary(Dictionary)>>at:ifAbsent:
SystemDictionary(Dictionary)>>at:
SmalltalkImage>>at:
SmalltalkCIPharo13 class(SmalltalkCIPharo class)>>packageNamed:ifAbsent:
SmalltalkCIPharo13 class(SmalltalkCIPharo class)>>classesInPackage:
[ :packageName | SmalltalkCI platformClass classesInPackage: packageName ] in [ :class | (self theNonMetaClassOf: class) packageNamesUnderTest
            gather: [ :packageName | SmalltalkCI platformClass classesInPackage: packageName ]] in SCIPharo12CodeCoverage(SCICodeCoverage)>>allPackagesUnderTestOf: in Block: [ :packageName | SmalltalkCI platformClass cla[..]
[ :each | stream nextPutAll: (aBlock value: each) ] in [ :stream | self do: [ :each | stream nextPutAll: (aBlock value: each) ] ] in Array(SequenceableCollection)>>flatCollect: in Block: [ :each | stream nextPutAll: (aBlock value: ea[..]
Array(SequenceableCollection)>>do:
[ :stream | self do: [ :each | stream nextPutAll: (aBlock value: each) ] ] in Array(SequenceableCollection)>>flatCollect: in Block: [ :stream | self do: [ :each | stream nextPutA[..]
Array class(SequenceableCollection class)>>new:streamContents:
Array(SequenceableCollection)>>flatCollect:
Array(Collection)>>gather:
[ :class | (self theNonMetaClassOf: class) packageNamesUnderTest
            gather: [ :packageName | SmalltalkCI platformClass classesInPackage: packageName ]] in SCIPharo12CodeCoverage(SCICodeCoverage)>>allPackagesUnderTestOf: in Block: [ :class | (self theNonMetaClassOf: class) pac[..]
[ :each | col addAll: (aBlock value: each) ] in Set(Collection)>>flatCollect:as: in Block: [ :each | col addAll: (aBlock value: each) ]
Set>>do:
Set(Collection)>>flatCollect:as:
Set(Collection)>>flatCollect:
Set(Collection)>>gather:
SCIPharo12CodeCoverage(SCICodeCoverage)>>allPackagesUnderTestOf:
SCIPharo12CodeCoverage(SCICodeCoverage)>>allClassesToCover
SCIPharo12CodeCoverage(SCIPharoCodeCoverage)>>allClassesToCover
SCIPharo12CodeCoverage(SCICodeCoverage)>>allMethodReferencesToCover
SCIPharo12CodeCoverage(SCICodeCoverage)>>startUp
SCIPharo12CodeCoverage(SCIPharoCodeCoverage)>>startUp
SCIPharo12CodeCoverage(SCICodeCoverage)>>run:
SCIPharo12CodeCoverage class(SCICodeCoverage class)>>run:spec:in:
[
            self prepareForTesting.
            self executionClass
                run: [ runner := self runTests ]
                spec: self spec
                in: self projectDirectory.
            self finishUpAfterTesting ] in SmalltalkCIPharo13(SmalltalkCI)>>basicTest in Block: [...
[ aBlock value ] in SmalltalkCIPharo13 class(SmalltalkCI class)>>fold:on:block: in Block: [ aBlock value ]
Ducasse commented 2 months ago

Yes this is normal since the image used to run the tests is using the code that contains the error too.