Fix Undeclared in Pharo 13

hpi-swa / smalltalkCI

Framework for testing Smalltalk projects with GitHub Actions, GitLab CI, Travis CI, AppVeyor, and others.

MIT License

94 stars 68 forks source link

Fix Undeclared in Pharo 13 #648

Closed demarey closed 2 months ago

demarey commented 2 months ago

Because of recent changes in Pharo 13, Smalltalk CI fails because it uses a class that has been renamed. The fix is to add this method in SmalltalkCIPharo13:

imageInfo
    ^ String streamContents: [ :stream | StSystemReporterPresenter new reportImage: stream ]

I did a PR but metadata writing from Pharo is not the same as in Squeak and there was a lot of noise. Tell me if you prefer the PR with metadata noise or if this issue is enough.

fniephaus commented 2 months ago

Hi @demarey, a PR would be nice. Maybe create it manually but adding a file for the method and adding it to the corresponding properties file?

fniephaus commented 2 months ago

cc @theseion

demarey commented 2 months ago

done in #649

theseion commented 2 months ago

Fixed by #646