search

hpi-swa / trufflesqueak

A Squeak/Smalltalk VM and Polyglot Programming Environment for the GraalVM.
MIT License
279 stars 14 forks source link

PolyglotInspector can't inspect hidden elements of large Arrays #143

Open janehmueller opened 3 years ago

janehmueller commented 3 years ago

Large arrays are shortened in the Inpsector so that the head and tail are displayed and the middle part of the array is hidden by an ellipsis. When clicking on that ellipsis, one can enter and index to inspect. This works with the base Inspector, but with the PolyglotInspector, the element is not found.

image image

fniephaus commented 3 years ago

Thanks! I've asked @LinqLover to take a look at this.

LinqLover commented 3 years ago

I just proposed a fix for Squeak Trunk, could you please confirm that it resolves the issue for you? :-)

[squeak-dev] Changeset: fix-generic-inspectOne-with-truncation.cs

The changeset will make its way into the Trunk as soon as someone approves and merges it ...

fniephaus commented 3 years ago

Excellent, thanks @LinqLover! With the changeset, the polyglot inspector seems to work fine. Great!

LinqLover commented 3 years ago

Great! Please feel free to merge the changeset into the Trunk if it looks good to you. :-)

fniephaus commented 3 years ago

Let me leave this to @marceltaeumel. He might be the better reviewer as he's familiar with the code already.