Implement sign-in method choice - Githubissues

hpi-swt2 / bookkeeper-portal-blue

Bookkeeper Portal — 🟦 Edition

MIT License

15 stars 0 forks source link

Implement sign-in method choice #299

Closed rgwohlbold closed 1 year ago

rgwohlbold commented 1 year ago

Fixes #284

This PR implements the split login page: The user can choose between signing in via email and via OIDC. Only when they click "sign in with email", they are forwarded to the regular sign-in page. This is performed via a custom SessionController with a URL parameter ?method=password.

This also alters a Devise view which isn't that nice, so I am open for new ideas.

PR checklist

[X] dev-branch has been merged into local branch to resolve conflicts
[X] tests and linter have passed AFTER local merge
[X] localization is supported (Guide)
[x] another dev reviewed and approved
[x] if feature-Branch: Teams PO has approved (show via e.g. screenshots/screencapture/live demo)

Peek 2023-01-17 20-43.webm

rgwohlbold commented 1 year ago

Does that fulfill the requirements? @benn02