Feature/br 134 groups as owners - Githubissues

hpi-swt2 / bookkeeper-portal-blue

Bookkeeper Portal — 🟦 Edition

MIT License

15 stars 0 forks source link

Feature/br 134 groups as owners #312

Closed fynnkroeger closed 1 year ago

fynnkroeger commented 1 year ago

Complets #134 #310

Description

This adapts the item so that owners can be groups or users. It does so on the new, show, and edit page.

TODOS

[x] items_controller.rb:88
[x] items_controller.rb:159
[x] use users_with_ownership_permission
[x] ~users_with_lend_permission~ will be seperate issue
[x] lending notifications
[x] testing

PR checklist

[x] dev-branch has been merged into local branch to resolve conflicts
[x] tests and linter have passed AFTER local merge
[x] localization is supported (Guide)
[ ] another dev reviewed and approved
[x] if feature-Branch: Teams PO has approved (show via e.g. screenshots/screencapture/live demo)

brokkoli71 commented 1 year ago

PO Review: loving it :D

antonneubauer commented 1 year ago

I took a look and it seems to me that the conflicts need to be resolved before a review makes sense