Sort-search-results button

hpi-swt2 / bookkeeper-portal-blue

Bookkeeper Portal — 🟦 Edition

MIT License

15 stars 0 forks source link

Sort-search-results button #330

Closed SaturnHafen closed 1 year ago

SaturnHafen commented 1 year ago

Fixes #325

The button is now available (but does not have any functionality).

Notes:

The button-padding will get fixed when #329 is merged
I am unsure about the Ergebnisse sortieren translation

PR checklist

[x] dev-branch has been merged into local branch to resolve conflicts
[x] tests and linter have passed AFTER local merge
[x] localization is supported (Guide)
[x] another dev reviewed and approved
[x] if feature-Branch: Teams PO has approved (show via e.g. screenshots/screencapture/live demo)

LucasDerReisende commented 1 year ago

Can you add a screenshot of the Button, so I can so how it looks like? :)

SaturnHafen commented 1 year ago

It looks like this :)

(desktop, extended, english)

(desktop, english)

(mobile, english)

(mobile, extended, german)

LucasDerReisende commented 1 year ago

Looks good! Could you just change the text to "Sortieren nach" and "Sort by" respectively? :)

LucasDerReisende commented 1 year ago

Looks good 😀. The only thing I'm not sure about is the different colors of the filter button and the sort dropdown menu. Any opinions on that @LucasDerReisende 🤔?

Good of you to mention it. It think it should be consistent with the filter button and in my opinion the design on the Dropdown menu looks better. We also have different fonts weights on these two interfaces which is not ideal.

SaturnHafen commented 1 year ago

The "problem" with that is that the button is styled the same way as everywhere else. We don't have a unified style for dropdown menus. If I change the button style the search might look better (locally) but wouldn't fit into the application.

We should probably discuss this in person tomorrow.

LucasDerReisende commented 1 year ago

Yes, let's talk about it tomorrow