Add UI to edit item permissions

hpi-swt2 / bookkeeper-portal-blue

Bookkeeper Portal — 🟦 Edition

MIT License

15 stars 0 forks source link

Add UI to edit item permissions #332

Closed lukasrad02 closed 1 year ago

lukasrad02 commented 1 year ago

This PR adds ui elements to the new and edit pages of each item to define which group(s) can see and which one(s) can lend this item.

PR checklist

[x] dev-branch has been merged into local branch to resolve conflicts
[x] tests and linter have passed AFTER local merge
[x] localization is supported (Guide)
[ ] another dev reviewed and approved
[ ] if feature-Branch: Teams PO has approved (show via e.g. screenshots/screencapture/live demo)

lukasrad02 commented 1 year ago

@benn02 our implementation supports selecting and deselecting groups for the two permission levels, both during creation and editing. The permissions are persisted and shown the next time when editing the item.

https://user-images.githubusercontent.com/49586507/214089523-c9254a32-d245-4729-8004-685cb285e31d.mp4

Sohn123 commented 1 year ago

The UI works as expected. But I think it isn't very intuitive for a user. If I miss click once, I have to reload the form in order to get the old state back. And it is very unclear what happens if I give a user see-permissions and lend-permissions and then revoke the lend-permissions. I think moving the permissions to an extra page, with a searchable list of all groups where I can configure the permissions with radio buttons, would be superior. But I think this is a decision @benn02 has to take.

benn02 commented 1 year ago

The UI works as expected. But I think it isn't very intuitive for a user. If I miss click once, I have to reload the form in order to get the old state back. And it is very unclear what happens if I give a user see-permissions and lend-permissions and then revoke the lend-permissions. I think moving the permissions to an extra page, with a searchable list of all groups where I can configure the permissions with radio buttons, would be superior. But I think this is a decision @benn02 has to take.

As Mentioned in the Issue, I want this to get done. I think the proposed solution by @Sohn123 is better, but it is up to you whether you want to rework this since I am also fine with the current version

Greenscreen23 commented 1 year ago

The UI works as expected. But I think it isn't very intuitive for a user. If I miss click once, I have to reload the form in order to get the old state back. And it is very unclear what happens if I give a user see-permissions and lend-permissions and then revoke the lend-permissions. I think moving the permissions to an extra page, with a searchable list of all groups where I can configure the permissions with radio buttons, would be superior. But I think this is a decision @benn02 has to take.

As Mentioned in the Issue, I want this to get done. I think the proposed solution by @Sohn123 is better, but it is up to you whether you want to rework this since I am also fine with the current version

We can also create a follow up issue, if you really want to get this done quickly. Lukas and I already spend our weekly time on this, so this probably won't be rewritten till next week.

Sohn123 commented 1 year ago

Ok if @benn02 says this is fine, then :shipit: