hpi-swt2 / bookkeeper-portal-blue

Bookkeeper Portal — 🟦 Edition
MIT License
15 stars 0 forks source link

Groups with 0 Owners are not possible #360

Open benn02 opened 1 year ago

benn02 commented 1 year ago

User stories

As a User, I want Groups with 0 Owners to be not possible in order to not crash if they have none

Acceptance Criteria

Greenscreen23 commented 1 year ago

I'm not really sure why this should be a feature. We currently have the option for groups that don't have a specific owner, so called "system groups". F.e. the default hpi group is working as intendend.

Is this ticket about these groups, or should users be able to create a group that does not have an owner?

benn02 commented 1 year ago

If that is working as intended and you can choose these Groups When creating an Item as Groups with permissions then you could also implement that the last owner cant leave the group or demote himself because either way we dont want broken groups. Either by just saying they are not broken (the original idea of this issue) or by forcing group owners to stay in their group and not destroying it in the first place

Greenscreen23 commented 1 year ago

If that is working as intended and you can choose these Groups When creating an Item as Groups with permissions then you could also implement that the last owner cant leave the group or demote himself because either way we dont want broken groups. Either by just saying they are not broken (the original idea of this issue) or by forcing group owners to stay in their group and not destroying it in the first place

I think it's reasonable to implement it like this:

And I don't change the underlying Model, e.g. groups are only valid if they are a System Group or they have at least one owner.

or is this something that's already being implemented by a different Team?