hpi-swt2 / compass-portal-blue

Compass Portal — 🟦 Edition
MIT License
6 stars 1 forks source link

Restyle language switch #233

Closed JulianEgbert closed 2 years ago

JulianEgbert commented 2 years ago

image It now highlights the current language in blue (in this case German). Before it was the other way around.

codecov[bot] commented 2 years ago

Codecov Report

Merging #233 (b27c837) into dev (f56ec32) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #233   +/-   ##
=======================================
  Coverage   98.72%   98.72%           
=======================================
  Files          26       26           
  Lines         470      470           
=======================================
  Hits          464      464           
  Misses          6        6           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f56ec32...b27c837. Read the comment docs.

anonym-HPI commented 2 years ago

@JulianEgbert Thanks for your pull request, but this would create the problem that the clickable link is grey.

I would propose something like this: grafik english being active in this example (the blue tone, should be the same, as the color of the clickable link).

JulianEgbert commented 2 years ago

If I understand correct you want this to be a button that shows the language you can switch to instead of the one selected, now I see... I can check if I can recreate what you described in your picture although this might get a little tricky...

anonym-HPI commented 2 years ago

If I understand correct you want this to be a button that shows the language you can switch to instead of the one selected, now I see... I can check if I can recreate what you described in your picture although this might get a little tricky...

The current selected language should have a blue background and the selectable white/grey background and the letters are blue (like a link). Did you understand it that way?

JulianEgbert commented 2 years ago

image It now looks like this, when German is the selected language.