Closed niklasmohrin closed 2 years ago
Merging #262 (7d8641c) into dev (efa1a2f) will increase coverage by
0.00%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## dev #262 +/- ##
=======================================
Coverage 98.75% 98.75%
=======================================
Files 36 36
Lines 881 884 +3
=======================================
+ Hits 870 873 +3
Misses 11 11
Impacted Files | Coverage Δ | |
---|---|---|
app/helpers/routing_helper.rb | 100.00% <100.00%> (ø) |
|
app/models/person.rb | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update efa1a2f...7d8641c. Read the comment docs.
Ah, in all of my testing, I never noticed that we apparently removed navigating to coordinates at some point? This of course disallows inputting a person's coordinates too. I don't really see why we wouldn't allow coordinates, so should it just be added back in? (in a separate PR, possibly by someone else, that is)
Closes #218
rubocop -A
I couldn't really get the "Directions" buttons to float / justify / align to the right completely, maybe some CSS guru here has an idea? If not, I think it looks okay enough right now