hpi-swt2 / compass-portal-blue

Compass Portal — 🟦 Edition
MIT License
6 stars 1 forks source link

Feature/cmjd 70 room schedule (more like "calendar refinement") #263

Closed Storyxx closed 2 years ago

Storyxx commented 2 years ago

This branch adds all the features that the #126 branch was missing like:

There are also a few refinements like:

Storyxx commented 2 years ago

Does anyone have an idea what to do about the too many lines problem from CodeFactor? Is there a possible refactor that would reduce this line-count? If so, please suggest a solution or simply push to this PR 😀

codecov[bot] commented 2 years ago

Codecov Report

Merging #263 (1821fc3) into dev (d2bfd54) will increase coverage by 0.75%. The diff coverage is 89.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #263      +/-   ##
==========================================
+ Coverage   97.93%   98.69%   +0.75%     
==========================================
  Files          35       36       +1     
  Lines         825      845      +20     
==========================================
+ Hits          808      834      +26     
+ Misses         17       11       -6     
Impacted Files Coverage Δ
app/helpers/routing_helper.rb 100.00% <ø> (ø)
app/controllers/search_results_controller.rb 90.78% <83.33%> (+8.18%) :arrow_up:
app/controllers/calendar_controller.rb 100.00% <100.00%> (ø)
app/models/event.rb 100.00% <100.00%> (ø)
app/models/search_result.rb 100.00% <100.00%> (+9.09%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d2bfd54...1821fc3. Read the comment docs.