search

hpi-swt2 / lecture-portal

Software for organizing and managing lecture participation
https://hpi.de/plattner/teaching/winter-term-201920/softwaretechnik-ii.html
MIT License
4 stars 1 forks source link

As a German, I always want to use the standard timepicker with military time format in the lecture settings. #235

Closed Blatzheim closed 4 years ago

Blatzheim commented 4 years ago

DEP: None AC:

adrianjost commented 4 years ago

Not possible to implement with HTML Standard. https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/time You need to setup your system correctly in the language you want to use. Browsers do this on purpose and there is no way to enforce another format from dev perspective except implementing your own timepicker.

MartinBuessemeyer commented 4 years ago

@adrianjost please look at this: https://stackoverflow.com/questions/32609407/html-input-time-in-24-format. Wouldn't be that sufficient?

adrianjost commented 4 years ago

yes we found that as well but if we would use this we would probably use some accessibility features and it is bad practice to work against browser settings that are there because the user has set up something in a way.

MartinBuessemeyer commented 4 years ago

OK I would say it is up to @Blatzheim to decide. I will move the issue back to the backlog for now.

adrianjost commented 4 years ago

I agree. @Blatzheim also keep in mind that any 3. party picker may have issues on mobile devices as well.

essal0815 commented 4 years ago

Just moved back because of kanban limits. According to github logs seems to be the latest added.

adrianjost commented 4 years ago

Nach Diskussion mit Alex soll der Timepicker so bleiben wie er ist, aber ein polyfill für Safari Desktop (und alle anderen Browser die den Type noch nicht kennen) eingerichtet werden.

adrianjost commented 4 years ago

Something like this would be a great fit: https://github.com/chemerisuk/better-timeinput-polyfill/blob/master/README.md