hpi-swt2 / sport-portal

Manage and organize sport events and sports leagues
GNU General Public License v3.0
18 stars 7 forks source link

Configure Matches #197

Open PoJo93 opened 7 years ago

PoJo93 commented 7 years ago

AS the organizer of an event I WANT TO configure how the games are played saying that I want to set the game mode, determine when someone wins and configure how many points the winner, as well as the looser, earns TO control how each match will be played

ACCEPTANCE CRITERIA

nikriek commented 6 years ago

Please modify the function after https://github.com/hpi-swt2/sport-portal/pull/292 is merged to reflect the different game modes in the point calculation

PoJo93 commented 6 years ago

@citron0xa9 I don't see a Field for the Best of: option

citron0xa9 commented 6 years ago

@PoJo93 should be fixed now

PoJo93 commented 6 years ago

@citron0xa9 ok nice. According to the User story there are three points missing

  1. When I click on the drop-down menu next to "Gewinnregel je Spiel" there is one option which says "Sieger ist, wer die meisten Sätze gewinnt" (Currently Gewinnregel and most sets)

  2. "When I hover over the label you can see "(z.B. Fussball = Best-of-1, Tennis = Best-of-3)""

  3. If I enter a negative value the error message is in english. Should be german (general criteria)

citron0xa9 commented 6 years ago
  1. Ok, will fix that
  2. should be possible, maybe you didn't hover over the correct label? If so maybe the ux is not optimal
  3. I can try to change that but could be hard
citron0xa9 commented 6 years ago
  1. add model validation for point limit (currently only in view)