search

hpi-swt2 / vm-portal

A Ruby on Rails application for managing virtual machines via VMware vSphere
MIT License
3 stars 1 forks source link

Password field for GitHub user on settings page #549

Open krichly opened 5 years ago

krichly commented 5 years ago

The password for the GitHub user should be configurable on the settings page, as it is not useful to be able to change the GitHub user but not the password.

BraunTom commented 5 years ago

@krichly We do not need to be able to specify a github password, because we use ssh keys (take a look at Setup). Username and email seems only relevant that is knows who executed git commands

chrisma commented 5 years ago

we use ssh keys

While this is usually a great idea for daily developer use, it might not be ideal in this scenarion, as it involves generating and fiddling with ssh configs (as described in the setup) in order to setup the system. Using name + pw might actually be simpler.