hpi-swt2 / workshop-portal

A Ruby on Rails app to manage workshops

http://workshopportal.herokuapp.com/

MIT License

21 stars 13 forks source link

US_3.3: Applicants overview #23

Closed julisa99 closed 7 years ago

julisa99 commented 7 years ago

As organizer

I want to have an overview with all applicants (personal data, how often already applied, how often accepted / rejected)

in order to give new rejected applicants a new chance.

estimation: 13 new estimation: 1

Tasks

[x] Table for Workshop Applicants
[x] Buttons for other required features
[x] Add gender and age
[x] Add number of participation to User
[x] Add application_letter details page
[x] Polish interface design
[x] Manage visibility options (e.g. not for pupil)

Acceptance criteria

When a user logs into the workshop portal, and selects one workshop, he / she should see this overview page. See UI wireframe for overview
When the user clicks on "details", the following page is displayed: See UI wireframe for details
Pupils can not see these two pages.
Coaches and organizers see all applications of the opened workshop.
Data of the current data base state is visualized correctly.

tobiasduerschmid commented 7 years ago

Feedback on the current state on heroku:

[x] Please remove the issue numbers and texts in order to provide a good feeling of the view.
[x] Please move the back button to the left.
[x] Please swap the accept all and print all button positions in order to provide a chronological flow from left to right.
[x] Please adjust the theme of red buttons to have a bright text color in order to improve readability.
[x] Please do not cut of the text (e.g. "Anzahl der angeno..."). Please break them in two or more lines, if necessary
[x] Please show the buttons in one or more rows with same width in order to have a consistent UI.

tobiasduerschmid commented 7 years ago

BUG: In the pupils overview, the "Bewerber" should be "Bewerbung"

tobiasduerschmid commented 7 years ago

Bewerbungs -> Bewerbungen

MasterCarl commented 7 years ago

I noticed you created some tests in events_spec.rb. Would you mind if I moved them into event_spec.rb or renamed them to avoid confusion? That would be part of #116.

ekrebs5 commented 7 years ago

You mean whether the feature test should be singular (event_spec.rb) or plural (events_spec.rb), right? It would be great if the scrum masters @Baschdl could make a convention for this for all teams.

(I am ok with singular, but at the moment we have half singular half plural, so this decision should probably be made for all teams simultaneously)

bjrne commented 7 years ago

@ekrebs5 I added it to my list, we'll discuss it on thursday/friday this week :)