refactor application letter factory

[aloeser]

we now use traits instead of inheritance

[aloeser]

One thing I'm not sure about is whether to put the traits into or below the factories, like

factory :application_letter do

    trait :accepted do
          status :acccepted
    end
end

trait :rejected do
    status :rejected
end

Any comments or ideas?

[aloeser]

Nevermind, 1min debugging with rails console helped. Putting them below factories makes them globally available, so that you can run FactoryGirl.build(:event, :accepted) which doesnt make sense. I'll change it soon