hpi-swt2 / workshop-portal

A Ruby on Rails app to manage workshops
http://workshopportal.herokuapp.com/
MIT License
21 stars 13 forks source link

Fix Heroku deploys #654

Closed cmfcmf closed 7 years ago

cmfcmf commented 7 years ago

Probably due to a Postgres update, the database now is more restrictive when it comes to changing a column's type. The Heroku deployment failed for this reason. I have already confirmed this fix to be working by manually applying it to the currently deployed version. You'll see it running over here: http://workshopportal.herokuapp.com/

Things left to do:

bjrne commented 7 years ago

Brilliant catch! 💾 rake migrate doesn't work at the moment due to the error 2 is out of range for ActiveRecord::Type::Integer with limit 0. I can fix this later. I opened an issue for the remaining tasks, #655.

bjrne commented 7 years ago

Should we really run migrations on deployment? Shouldn't we rather use db:setup in the release version? If we want to see whether it succeeds I'd rather write a test (if possible) that tries migrating with postgres.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 538f7f17bf163b17c79f8a4529d3c3bea35c47d2 on fix-heroku into 288494c3bd04460e741dd1adae93a5ad5cc87cd3 on dev.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 79ec56d6040dc790f75cb6eb119c95330775cbb5 on fix-heroku into 87ef77560d0fa1f6b658e07800dfa913f37d598a on dev.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 9e65724fcc66f92362e15b3266e3f02c32640328 on fix-heroku into 2f5695c361979fdd51ef40226012b9fef08ce10d on dev.