fixes #520 misleading draft actions - Githubissues

hpi-swt2 / workshop-portal

A Ruby on Rails app to manage workshops

http://workshopportal.herokuapp.com/

MIT License

21 stars 13 forks source link

fixes #520 misleading draft actions #665

Closed corinnaj closed 7 years ago

corinnaj commented 7 years ago

We now have actual buttons, instead of radio buttons for drafts. It is not possible to unpublish events, I wasn't sure if that is a useful feature, but it should be possible to reintroduce that quickly, if necessary.

I wasn't sure what our conventions for buttons in tests are, so they might have to be refactored.

coveralls commented 7 years ago

Coverage decreased (-71.1%) to 28.878% when pulling 6048fc48df2b0ed188d2063821faf4c0d6f5c854 on 520_misleading_draft_actions into b6beaeb212ab6abd06bbded744dd1f25852cbf95 on dev.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling 05e2f81c1b7feada9957ef0ebd094076c687fdbd on 520_misleading_draft_actions into b6beaeb212ab6abd06bbded744dd1f25852cbf95 on dev.

corinnaj commented 7 years ago

I am not sure what you mean... I removed the one remaining git conflict, I think it should be fine now.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling e088319aa8ed2b01011735e8cd051ae1dacaa1e9 on 520_misleading_draft_actions into a84b8900ecc2223f0c8f4bb6d28e109a024d125b on dev.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling cd2828d1b7513df9467239690863601791328ca2 on 520_misleading_draft_actions into b6cd304084dd8728c29948e370a8841b7da219bd on dev.

annkatrinkuessner commented 7 years ago

We decided that our style guideline is to use internationalization for the tests instead of ids. It would be amazing if this could be adapted before merging :)

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling 3b9d923e76634deae509485f6863cc80c43739b8 on 520_misleading_draft_actions into eb9698df9d331142c142e4d3e75b0cd64b8998b8 on dev.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling 3b9d923e76634deae509485f6863cc80c43739b8 on 520_misleading_draft_actions into eb9698df9d331142c142e4d3e75b0cd64b8998b8 on dev.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling 78541abfe1032784d91eebd3ff0805fa51fc3526 on 520_misleading_draft_actions into eb9698df9d331142c142e4d3e75b0cd64b8998b8 on dev.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling 60d8ec62d7ab1cd35703d7c39d6f4270f631c23d on 520_misleading_draft_actions into eb9698df9d331142c142e4d3e75b0cd64b8998b8 on dev.

corinnaj commented 7 years ago

I updated all test to use I18n instead of ids. There is only one rubocop issue remaining, which I propose to fix in another PR, as it's more of a general problem and not part of this issue.

coveralls commented 7 years ago

Coverage remained the same at 100.0% when pulling 3655b17ee8a34b62eb47a502962a0bb45fac54c0 on 520_misleading_draft_actions into eb9698df9d331142c142e4d3e75b0cd64b8998b8 on dev.

querenker commented 7 years ago

That the classes are too long is indeed a general problem... The rubocop todo file is now adjusted accordingly :)