add encryption/decryption support, fix lots of corner cases, some refactorings/renames

hpk42 / muacrypt

Autocrypt and more for Mail User Agents

Other

36 stars 15 forks source link

add encryption/decryption support, fix lots of corner cases, some refactorings/renames #41

Closed hpk42 closed 6 years ago

hpk42 commented 6 years ago

addresses #22 by adding encrypt_mime/decrypt_mime API to account.
fix lots of corner cases for mime parsing, also wrt to content-transfer-encoding and py2/py3 encodings
strike unused code
renamed/refactored towards more consistency

this is now able to process 44K mails of my mailbox, and also decrypt encrypted ones.

juga0 commented 6 years ago

As you pointed out for #15 and #5 (and i agreed and closed myself), PRs with so many commits and files changes are hard to review. Could you please split this PR so it can be reviewed easier?. Thanks.

azul commented 6 years ago

I had a quick look at the compiled changes and each commit in turn. Moving process_incoming and process_outgoing out of account manager looks good to me. Same for the change in creating AC headers (not including the header name as a arg to the function.)

I obviously cannot check all the cornercases you tested with your inbox. Also am a bit lost on python specifics.

Workaround for gpg 2.0 looks fine to me. So i think this is ready to roll and we can take it from there.

hpk42 commented 6 years ago

@juga it's true that it's hard to review. things in muacrypt are currently a lot in progress, and especially the encrypt/decrypt handling took me many iterations to make it succeed in parsing my own mailbox. Lots of tests added, and all passing helps to get confidence. hope that muacrypt enters a more stable state with smaller PRs soon. muacrypt is not "py-autocrypt" anymore, it has a different focus and i don't expect autocrypt folks to follow each of the (often unrelated) commits.