hpk42 / muacrypt

Autocrypt and more for Mail User Agents
Other
36 stars 15 forks source link

Add OpenPGP operations using PGPy instead of BinGPG #7

Closed juga0 closed 7 years ago

juga0 commented 7 years ago

With respect to #5, changes are:

hpk42 commented 7 years ago

Hey juga! this PR looks quite good, just two minor issues as commented inline. Happy to see integration of pgpy moving forward.

juga0 commented 7 years ago

I'm rebasing to solve conflict with init.py. Which should be the version?, 0.4.1.dev1?

azul commented 7 years ago

Is there a need to bump the version? The new approach so far has not been exposed or included. I would tend to just add it and leave the version as is. But I am not familiar with versioning practices in python community. If you want to increase the version 0.4.1.dev1 seems to make sense to me.

juga0 commented 7 years ago

Rebased and add new commit with the proposed changes. I don't know if it's preferred to rebase and ammend the new changes or to merge.

azul commented 7 years ago

@juga0 thanks a lot. I went through the fixup commits and they all look good. Rebased so easy to merge and tests are green. :green_heart: :smile: I'll go through the diff again and see if i spot sth. else and otherwise just merge.

azul commented 7 years ago

@juga0 Looks good. Thanks a lot!

juga0 commented 7 years ago

Thank you