alvations
commented
5 years ago The license file is left out on purpose. I don't own the moses project and this port done out of convenience. I guess the @moses-smt maintainers know that this repo exists and have let it continue to exist.
The issue with LGPL from Moses' license is
Conveying Modified Versions.
If you modify a copy of the Library, and, in your modifications, a facility refers to a function or data to be supplied by an Application that uses the facility (other than as an argument passed when the facility is invoked), then you may convey a copy of the modified version:
a) under this License, provided that you make a good faith effort to ensure that, in the event an Application does not supply the function or data, the facility still operates, and performs whatever part of its purpose remains meaningful, or b) under the GNU GPL, with none of the additional permissions of this License applicable to that copy.
-
If you modify a copy of the Library : Actually, I'm not sure whether I've modified a copy of the library. I reimplemented from scratch for another language and accommodations / improvements were made to the original algorithm, not the library itself.
- an Application does not supply the function or data, the facility still operates, and performs whatever part of its purpose remains meaningful: If I would to translate that to words I understand, "if you provide a library that uses the modified function, the function should still operates and produce the desired meaningful output that the original should."
- if the original Perl script outputs space-joined strings and the Python version outputs
list(str)as token, it should be equally meaningful but the whole stream in, stream out purpose of the original Perl tokenizer script has been converted into a function-return mecahnism, so I'm not sure whether the current port compiles to the LGPL requirments.
And I don't want to change the license to GPL from LGPL unnecessary to respect the original Moses' maintainers' stance on keeping the LGPL, so as a layman not knowing legalese, I have choosen to just repeat the license heading in the README.md
GNU Lesser General Public License version 2.1 or, at your option, any later version.
I'm not a lawyer or well-versed in license but if there's any lawyer who would like give their professional advice and consultation on what should be done in terms of licensing of this repository, please feel free to comment in this issue.
BTW, mosestokenizer is another library that's a Python wrapper to the Perl code, also in https://github.com/moses-smt/mosesdecoder/tree/master/scripts/tokenizer/mosestokenizer. I've changed the header to sacremoses to avoid confusion.
BLKSerene
Hi, I'm using the python port of Moses Tokenizer in my project, I would appreciate it if you add a LICENSE file and copyright information to the repository.
And what's the official name for this python port of Moses Tokenizer,
sacremoses(the module name) ormosestokenizer(as in the title of the doc)?