hplush / slowreader

Web app to combine feeds from social networks and RSS and to help read more meaningful and deep content
https://dev.slowreader.app
GNU Affero General Public License v3.0
161 stars 37 forks source link

Add <meta> tag for `theme-color` attribute #126

Closed privorotskii closed 7 months ago

privorotskii commented 7 months ago

Fixes issue

Motivation

Screenshot or video

Chrome Android:

Before After
image image

Safari (no changes):

Before After
image image
image image

Checklist

privorotskii commented 7 months ago

Hey @ai, I think I'm a bit stuck here Here's what I tried and why it didn't work out:

So what I did in order to get the working version is taking the actual background colors via colorPicker and converting them to oklch. I added those values as new CSS properties, but it doesn't feel like a good way to handle it:

Does it make sense to do it this way or it's better to wait for better support from browsers? Or are there any better ideas? I'm open to any discussions and suggestions

ai commented 7 months ago

Good research 👍. I suggested a way to avoid browsers limits.

ai commented 7 months ago

Next time, don’t forget to run pnpm test before creating PR.

privorotskii commented 7 months ago

@ai I did, it passes for me on this branch. Was something wrong after merging? Asking in case it behaves differently on different machines or not

image

ai commented 7 months ago

Size Limit was wrong.

https://github.com/hplush/slowreader/actions/runs/8507486659

Maybe after rebasing on new main branch.