Value data from feeds/add/{data} doesn't passed directly to input where it was previously added

[dancetrain]

Steps to reproduce:

• Open http://localhost:5173/feeds/add/
• Add value to Web page URL or social account handle input field (example: https://soundcloud.com/redaxes/flawless-club-mix-feat-echo)
• Observe how URL is changed regardless of errors (example: http://localhost:5173/feeds/add/https%3A%2F%2Fsoundcloud.com%2Fredaxes%2Fflawless-club-mix-feat-echo)
• Refresh the page - value from URL is not returned to input box

[kmpeeduwee]

I want to take it

[ai]

Sure, it is your.

[kmpeeduwee]

@ai Hi! I found how to implement this. But something tells me that this is not quite the correct way to add this code to onMount in preview.ts. Can you comment on this approach?

onMount($candidates, () => {
  let page = router.get()
  page.route === 'add' && setPreviewUrl(page.params.url!)
  return $links.listen(() => {})
})

[ai]

Looks normal in terms of API. But I don’t understand why we have $links.listen(() => {})

Also, if we use router, we usually need to subscribe to it. Can you explain why we didn’t subscribe?

[kmpeeduwee]

@ai I apologize, but this was due to my not understanding the code well enough; it was a piece of old code. I propose this version, in which I subscribe to the router and return the unsubscribe function:

onMount($candidates, () => {
  let unsubscribeRouter = router.subscribe(page => {
    if (page.route === 'add') {
      setPreviewUrl(page.params.url!);
    }
  });

  return () => {
    unsubscribeRouter();
  };
});

[ai]

Fixed 506c628