Closed upteran closed 7 months ago
Do we need to add two components with different theme prop configurations, or is the Base enough?
Yes, we need separated stories.
The problem with theme switcher is that we can’t use it on Chromatic (screenshot based testing).
Another reason is that now checking Storybook by eyes is very straight-forward—you just going from one story to another and check it by eyes. With theme switcher you need to remember to manually test every story in different themes, which is more complex than clicking Next Story
.
Fixes #118
Motivation
The changes were made to the styles in the formatter text component to enhance the visual appeal and readability of the long heading text.
Screenshots
Few screenshots to show some frequently used tags. The entire list of other tags has been added to the story.
Checklist
scripts/
, add a comment with a description.README.md
.README.md
.node_modules
size, and subdependencies number.cd web && pnpm size
, check the JS bundle size changes, about limits if necessary.core/
. What code will also be useful on other platforms?pnpm size
and check the difference in the JS bundle size. Is it relevant to the changes? Change the limit inweb/.size-limit.json
if necessary.index.html
.core/
:Questions during PR:
I have few questions about PR:
createTable
function to build table examples, but I'm not sure if it's necessary because it's probably complicated code a simple few row/cell table by string might be enough.