Closed sanchopanda closed 4 months ago
Pull request auto-reviewer
Since you’ve made changes to files in web/main/
consider these points:
web/public/404.html
or web/public/500.html
?index.html
.Pull request auto-reviewer
Since you changed core/
:
Pull request auto-reviewer
Since you’ve made changes to files in web/main/
consider these points:
web/public/404.html
or web/public/500.html
?index.html
.Pull request auto-reviewer
Since you changed core/
:
Pull request auto-reviewer
Since you’ve made changes to files in web/main/
consider these points:
web/public/404.html
or web/public/500.html
?index.html
.Pull request auto-reviewer
Since you changed core/
:
Sorry for repeating messages of auto-reviewer. We are still in the development this feature.
I'm very sorry for taking so long. It probably requires a lot more improvements, but at least it works.
No-no, it is a really complex task. Thanks.
I will review in a few days (need a recovery after the conferences).
Can you write me to @sitnik
?
I will give you my OPML file. When I try to use it, import page rendered this (everything OK), but Import
button doesn’t work.
The same with loader-tests/example.opml
It works, amazing!
I will do a little deeper review later. But we need storybook and coverage.
BTW, do you have Telegram or Discord? You can write me to https://t.me/sitnik
I will do a little deeper review later. But we need storybook and coverage.
Yes, I struggled with tests, now working on it
BTW, do you have Telegram or Discord? You can write me to https://t.me/sitnik
seems ready for a new review)
Thanks a lot! It was big and complex work.
Fixes #177
Motivation
Screenshot or Video
Checklist
pnpm test
.scripts/
, add a comment with a description.README.md
.README.md
.core/
. What code will also be useful on other platforms?pnpm size
and check the difference in the JS bundle size. Is it relevant to the changes? Change the limit inweb/.size-limit.json
if necessary.web/main/
files:web/public/404.html
orweb/public/500.html
?index.html
.core/
: