Closed janefawkes closed 3 weeks ago
Now you need to fix tests (it is better to add some test for rate limit too) and we are ready to merge.
You can run tests by cd proxy
and pnpm test
.
You also need to fix ESLint warnings by calling eslint --fix .
ESLint warnings are fixed now.
Not sure what to do with tests, though. I am a bit stuck with them and I don't really know how to ensure proper coverage
Pull request auto-reviewer
[ ] If you added a new dependency, check our requirements.
Fixes #168
I sort of tested this by running the proxy and spamming it with batches of requests (like this). It works on my machine™, but
pnpm test
doesn't quite agree with it.Would love to hear any sort of feedback on this, because I'm not sure if I'm moving in the right direction or not.
Additional changes: proxy config and error handling have been divorced from the
createProxyServer
implementation.