Use glob in /scripts - Githubissues

hplush / slowreader

Web app to combine feeds from social networks and RSS and to help read more meaningful and deep content

https://dev.slowreader.app

GNU Affero General Public License v3.0

161 stars 37 forks source link

Use glob in /scripts #248

Closed 3timeslazy closed 2 months ago

3timeslazy commented 2 months ago

Fixes #239

github-actions[bot] commented 2 months ago

Pull request auto-reviewer

Think about code testing.

ai commented 2 months ago

CI is broken to fix it:

Run eslint --fix . to sort variables
Add fs.globSync to ignore of n/no-unsupported-features/node-builtins rule in ESLint config

github-actions[bot] commented 2 months ago

Pull request auto-reviewer

Don’t rush. Check all changes in PR again.
Run pnpm test.
Think about changing documentation.
- If you added a script to scripts/, add a comment with a description.
- If you added a new folder, add its description to the project’s README.md.
- If you added config, describe how we use this tool in the config’s comment.
- Try to focus on “why?”, not “how?”.

3timeslazy commented 2 months ago

@ai btw, it seems like check-version does not check Dockerfile versions. It matches against node: (\d+\.\d+\.\d+) pattern while Dockerfiles have NODE_VERSION (\d+\.\d+\.\d+) pattern. Should I fix it in this PR?

ai commented 2 months ago

Yes, this is issue.

Can you fix it here if in separated PR?

3timeslazy commented 2 months ago

Yes, this is issue.

Can you fix it here if in separated PR?

I'll fix it in a separate PR than

ai commented 2 months ago

Thanks!