hplush / slowreader

Web app to combine feeds from social networks and RSS and to help read more meaningful and deep content
https://dev.slowreader.app
GNU Affero General Public License v3.0
161 stars 37 forks source link

Scroll page above on Next page click #98

Closed ai closed 7 months ago

ai commented 8 months ago

On Fast posts page we have pagination and Show next button.

Now, after clicking on the button, page keeps scroll on the button of the page.

We need to fix it and scroll to top.

sanchopanda commented 8 months ago

I want to take it

sanchopanda commented 8 months ago

@ai I don't see the problem described. After clicking show next, scroll to the beginning of the feed https://monosnap.com/file/pE0u69zAycMun9GOhBTkbpu0kReSL1. Maybe I misunderstood the task?

ai commented 8 months ago

Try to use another button “Mark as read …”

sanchopanda commented 8 months ago

@ai At first I tried to implement it differently, i saved it in another branch. I assigned a link to an element to a key and calling scrolling on the element by key directly in core/fast, but then I changed it to just dispatching event in window.

sanchopanda commented 8 months ago

@ai At first I tried to implement it differently, i saved it in another branch. I assigned a link to an element to a key and calling scrolling on the element by key directly in core/fast, but then I changed it to just dispatching event in window.

I already read the comments, forget it)

ai commented 7 months ago

I just tried to read posts in https://dev.slowreader.app and scroll doesn’t work :(

ai commented 7 months ago

It works on small window height (540), but doesn’t work on big screen (1000).

sanchopanda commented 7 months ago

Ok, i'll take a look

sanchopanda commented 7 months ago

@ai I couldn't reproduce the problem, can you please describe it in more detail? https://monosnap.com/file/8KYyy6pYu7C9DNuS3jzmHszgXpq8iZ

ai commented 7 months ago
  1. I used Firefox
  2. I run local version of app (with the latest commit)
  3. After I clicked on Mark as read and next load it was not scrolled.
  4. When I open DevTools to reduce height (to make video smaller), the scroll started to work
  5. When I moved DevTools on the side, it stops working

Can you try Firefox? Maybe it is just browser related?