Support for string:binary. + more.

hpoul / openapi_dart

Dart implementation to generate (dart) server stubs and client libraries from OpenAPI 3.0 yaml files.

38 stars 18 forks source link

Support for string:binary. + more. #11

Open PROGrand opened 1 year ago

PROGrand commented 1 year ago

Description

support for string:binary in builder (Uint8List parser and json converter).
exposing ShelfRequest.request for using in handler implementations. Especially for shelf.Request.context interchanging between middlewares and handlers. For providing auth credentials from auth middleware to handlers for example.
support for latest code_builder (declareFinal patch).

hpoul commented 1 year ago

somehow this PR has quite a few formatting changes.. are you using dartfmt/flutter format?

PROGrand commented 1 year ago

ok. Now it is formatted using 'dart format'. (flutter )

$ dart --version
Dart SDK version: 2.19.6 (stable) (Tue Mar 28 13:41:04 2023 +0000) on "windows_x64"
$ dart format .
Formatted packages\openapi_base\lib\src\openapi_base.dart
Formatted packages\openapi_base\lib\src\openapi_exception.dart
Formatted packages\openapi_base\lib\src\server\openapi_shelf_server.dart
Formatted packages\openapi_code_builder\example\bin\example_server.dart
Formatted packages\openapi_code_builder\lib\openapi_code_builder.dart
Formatted packages\openapi_code_builder\lib\src\openapi_code_builder.dart
Formatted 26 files (6 changed) in 0.58 seconds.

hpoul commented 7 months ago

Would it. be possible to split the PR up into just adding binary support? Also is there some documentation in the specification for format: binary? I couldn't find anything.. the closest i came was to:

            type: string
            contentMediaType: image/png
            contentEncoding: base64

which doesn't use format at all 🤔

thanks

PROGrand commented 7 months ago

Hello, thank you for attention.

I unforced dependencies right now, so there are almost no dependency_overrides requirements with stable flutter. So it is most likely looks as your main branch with addition of:

binary support
upgraded deps
some cleaning (no pubspec.lock, removed comments)
gui app link supporting --http-base
added build_verify

Passes tests and runs without any problems. I have no plans to split PR, just because I completely satisfied with it.

string: binary is in opeanapi 3.0: https://swagger.io/docs/specification/data-models/data-types/#string