search

hpparvi / ldtk

Python toolkit for calculating stellar limb darkening profiles and model-specific coefficients using the stellar atmosphere spectrum library by Husser et al. (2013). Described in Parviainen & Aigrain, MNRAS 453, 3821–3826 (2015).
GNU General Public License v2.0
29 stars 19 forks source link

A2_redifining_stellar_edge.ipynb .core error #16

Open ericagol opened 4 years ago

ericagol commented 4 years ago

Hi @hpparvi - I am trying to run your ldtk example notebook in Python 3.7. When I do so, I receive the attached errors. Also below are the dependencies of my ldtk python install. Could you help me track down what is failing? Thanks in advance, Eric Agol

ldtk_notebook_error ldtk_dependencies_satisfied
hpparvi commented 4 years ago

Hi Eric,

Sorry, there were two problems that should both be fixed now. First, LDTk has mpi4py as an optional dependency (so that it can be run in an MPI environment), but mpi4py was not marked anywhere as a requirement, and not having it broke the code. This is fixed now and LDTk should work without problems also when mpi4py isn't installed.

Second, I hadn't updated (or tested) the A2 notebook since 2015, so it's probably been broken for some time already. I've now updated the notebook so that it works (and added the missing citations), but the resampling section is still not properly documented. The main point of this notebook is to show what LDTk does under the hood, but I may need to write some utility methods to visualise the raw and refined intensity profiles better.

Hope this helps. Please pull the changes (or update with pip), give it a go, and let me know if the problems still persist.

Cheers, Hannu

ericagol commented 4 years ago

Thanks for the quick work on this, @hpparvi ! I reran the pip install ldtk command, and downloaded the new A2 notebook.

Now I am getting an error in which the cached fits file is missing.

I then tried to download with LDPSetCreator, except that now the from ldtk import LDPSetCreator isn't working (see screen shot below).

I think I have been able to figure out how to compute what I need from another set of limb-darkening models based on Phoenix models used in Claret, Hauschildt & Witte (2012). My goal is to create a spherical limb-darkening model for the TRAPPIST-1 planetary system, and to fit this with a quadratic limb-darkening model to see if there is any bias/errror in the measured radii or impact parameter caused by using the quadratic model (see this repository).

ldtk_error_v2