search

hprange / wounit

The WOUnit framework contains a set of utilities for testing WebObjects applications using JUnit 4.7 or later capabilities.
http://hprange.github.io/wounit/
Apache License 2.0
19 stars 18 forks source link

Added support for entities that have a primary key of type Long #48

Closed Zigdra closed 6 years ago

Zigdra commented 7 years ago

Currently WOUnit does not support entities that have a primary key of type long.

This small change fixes the issue by using a long global fake id. It takes a look at the type of the PK and casts to long/int as needed.

It would be nice if the fix could be merged in both 1.3 and 1.2.

hprange commented 7 years ago

Hi Giancarlo,

First of all, thanks for providing a patch that fixes the issue. I really appreciate. In order to apply the patch for both WOUnit 1.2.x and 1.3.x, I decided to cherry pick your commit into the wounit-1.2.x branch. And then I merged that change into the master branch. So, don't worry about the status of your pull request right now. It's already merged.

Before I close the pull request and make a release, would you mind to test it? Just update the version in your pom.xml file. Otherwise, you can download wounit-1.3-SNAPSHOT and wounit-1.2.4-SNAPSHOT JARs if you aren't using Maven.

Zigdra commented 7 years ago

Hello Henrique,

sorry for the long delay. I just tested the snapshot version and everything looks fine. feel free to merge :)

Greetings Carlo

hprange commented 6 years ago

Merged!