search

hpreston / myhero_spark

Simple Cisco Spark Bot for the MyHero Demo
1 stars 2 forks source link

Msg spaming cause by Webhook #9

Open guillain opened 6 years ago

guillain commented 6 years ago

Hello,

First of all thanks a lot for your code! I see you this year in the Barecelona's Cisco live and it was an amazing session (devops). So it's why I tested your myhero code and that's very nice. If you need I creaed the docker(compose) settings.

So related to the issue, no protection is done on the webhook level so if no roomId is provided the message sniffing starts on lot of not expected room. Effectively to avoid that it can be better to fix (until to block?) the roomId during the setup.

Thanks for your feedback and have fun :-D

hpreston commented 6 years ago

Your welcome, and thanks for the feedback on the CLEUR sessions. I had a great time.

I'd love to see the docker-compose file for the application. I'm mid-way through updates for the app for Kubernetes, and providing a compose option as well would be great.

As for the web hook and bots... there are definitely a lot of considerations related to bot building to make sure things behave as desired and expected. Since building the original bot code for MyHero I worked on a project, http://github.com/imapex/ciscosparkbot, that provides a basic bot framework in Python that has some protections built in. The code in myhero here isn't what I would consider "best practice bot code", but rather just some toy demo code.

guillain commented 6 years ago

Thanks for your fast feedback.

About the spark bot, no issue it was for test only.

I'll create a pull request when the docker integration is finalized (spark, ernst and mosca done, tropo to do) I work also on stack deployment and will commit this one on the demo (I think ^^)

FYI I worked with a colleague on micro-framework for the chat bot/ops and we perform some interesting integration with (as relevant POC ^^): https://github.com/bernard357/shellbot Based on ZeroMQ, so can be adapted easily for your usage/integration

Have fun