CoderSchool.vn: Submission for assignment1

[hprobotic]

I know i has been too late. But please help me check this /cc @coderschoolreview

[minhchau273]

:+1: Fantastic job with the submission - one of the best of the week. The point of this homework was to explore a simple example of a full MVC application with a RESTful API. You learned about UITableViews, custom UITableViewCells, navigation from a UITableView, and basic networking.

Grading Summary:

• Functionality: Excellent
• Code Style: Good
• Visual Design: Outstanding
• Usability: Excellent

Overall: Outstanding

Detailed Notes

• Great clean code. Good job utilizing the best parts from the style guide:
  • Ray Wenderlich Swift Style Guide
• In future homework, we will cover how to implement models that can deserialize from an NSDictionary. SwiftyJSON is a useful project for making it easier to deserialize the JSON response. For a more robust solution, you can also investigate using an ORM like Pistachio.
• Your custom Movie cell should have a property called movie. In the custom setter of movie, you should configure the various labels and images. This decouples your custom cells from the table view controllers.
• Your images are loading synchronously. This will block the UI thread and make it so that your app appears frozen while the images are being downloaded.
• Note that your images are stretched. You should observe the UIContentMode of the UIImageView. By default, it will stretch the image to match your dimensions, which is probably not what you want.
• Your error message should be displayed if a network request fails and hidden again if it succeeds. Please try completing all the required functionalities.
• Consider a solution that allows a user to see the entire movie synopsis in the Movie Detail View. Right now it is being truncated. Allowing scrolling by adding a UIScrollView would fix that.
• Nice job keeping things nice and aligned on a grid. That helps the application look cleaner and make it easier for the user to find the correct information. For a lot more information, you can read Design tips for iOS9.
• There's a small issue with search bar. When I select a movie from the results, your app shows another movie details.
  
• When I tap Cancel then x button on the UISearchBar, your app crashes.
• It's not a big deal but in case there is no result, you should show a label No results found to make your app more friendly :wink:

Great job dedicating enough time to do the homework. You learned a lot! Keep up the good work.