[Intro to iOS] Prework - Review my app: Tip4

hprobotic / Tip4

Swift Tip Calculator App

2 stars 0 forks source link

[Intro to iOS] Prework - Review my app: Tip4 #1

Open hprobotic opened 8 years ago

hprobotic commented 8 years ago

Hello, my Tip4 (tip calculator) app is complete. Please review, thank you! /cc @coderschoolreview

harley commented 8 years ago

Resubmitting to @coderschoolreview

coderschoolreview commented 8 years ago

Thank you for your Swift submission, hprobotic!

:tada: Everything looks good with the format of your submission. We'll be reviewing your submission soon!

coderschoolreview commented 8 years ago

:+1: Good job with the Tip Calculator with the nice UI :wink:

Some small comments:

Good usage of the NSUserDefault. This is one of the methods to pass data between view controllers.
You shouldn't let the user enter invalid number, should you? I can enter bunch of leading zeros. I can also paste some text in the text field:
For now, I cannot input decimal number to amount text field.
It's a little confusing when you display only the tip for each person, not the total amount.

Congratulation on completing the prework! The result will be emailed you soon.

hprobotic commented 8 years ago

@coderschoolreview I will update my code follow your comment tonight. Thanks you

harley commented 8 years ago

Hi @hprobotic -- we sent you an email asking to confirm your attendance last week. Just in case you didn't receive that email from us, I also added you directly to our class Facebook group. I'm just checking if you heard from us. Thanks

hprobotic commented 8 years ago

Hi Harley

Morning friend, i'm so excited when hear about this. But i think we have small wrong. Can you recheck for me about Facebook group. I don't see any notification from facebook about this. Here is my facebook account: http://fb.com/cpt1512

Thanks

On 7 March 2016 at 09:13, Harley Trung notifications@github.com wrote:

Hi @hprobotic https://github.com/hprobotic -- we sent you an email asking to confirm your attendance last week. Just in case you didn't receive that email from us, I also added you directly to our class Facebook group. I'm just checking if you heard from us. Thanks

— Reply to this email directly or view it on GitHub https://github.com/hprobotic/Tip4/issues/1#issuecomment-193052032.