Thanks!

[coderschoolreview]

Hello! Thank you for submitting the first homework for CoderSchool React Class 🎉! The main focus of this assignment was to introduce you to working with an API, rendering items in a collection, and dealing with state and props.

Thanks for creating a nice README.md with the checkboxes. It makes it a lot easier to understand the functionality of your app.

• Good job fetching the data in App.js within componentDidMount callback.
• Good job when you have separated constants definitions in an other file.
• It's totally fine to do string concatenation like "API.root_url + 'movie/top_rated?api_key=' + API.token" but using templated strings would be preferred. (Reference here)[https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals] (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Template_literals#Tagged_template_strings)
• Cool job using semantic ui library. It's nice to use a CSS Framework because you can build off base styles easily and quickly.
• You did a good job splitting up into MovieList and MovieItem, keeping the code clean and simple.

[chug2k]

You forgot to make search case insensitive ;)

[hprobotic]

Yeah Thanks you @Charless. My bad :D

On Thu, Nov 30, 2017 at 5:06 PM Charles Lee notifications@github.com wrote:

You forgot to make search case insensitive ;)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/hprobotic/cs-muvee/issues/1#issuecomment-348141385, or mute the thread https://github.com/notifications/unsubscribe-auth/AFhgjScrRNWb2-n_IafTsdbrqvNugW6Cks5s7n4UgaJpZM4QwBOe .