Closed mayur-vachchewar closed 7 months ago
Looking good! Here are two things to cleanup:
There seem to be a lot of warnings in my testing:
... can you address those and also any other items a linter will find for PHP 8 environments?
The input fields and submit button don't quite duplicate the current look and feel of the plugin. Can you modify the styling to match?
Looking good! Here are two things to cleanup:
There seem to be a lot of warnings in my testing:
... can you address those and also any other items a linter will find for PHP 8 environments?
The input fields and submit button don't quite duplicate the current look and feel of the plugin. Can you modify the styling to match?
@MSmedal I have fixed the warning issues, and the UI. could you please review it once and let me know if anything
@mayur-vachchewar there still seem to be issues in terms of appearance and display. Here what it currently looks like in large viewports:
...and here is the way your PR renders:
The spacing between some input fields, the images we're loading, and especially the submit button all have problems. Please try to copy the look and feel of the current plugin.
This change has no effect because this public method isn't actually being used. Double-check to see where 'style.css' is actually being loaded, it isn't here.
@securesubmit-buildmaster @MSmedal This will only get reflect after changing the version example, as I am unable to reproduce the issue, so could you try with updating version mention --> define('GF_SECURESUBMIT_VERSION', '1.4.8');
In below images, the version of style.css is been refer to the plugin version.
Here is the file for reference : define('GF_SECURESUBMIT_VERSION', '1.4.8');
@MSmedal Could you please review the PR.