Closed ttnnkkrr closed 8 years ago
If you're worried about breakage, wrap it in an if statement like I suggested in another comment.
On Thu, Nov 3, 2016 at 7:57 AM -0400, "Charlie Simmons" notifications@github.com wrote:
@ttnnkkrr commented on this pull request.
In js/securesubmit/checkout-form.js:
+ if (typeof completeCheckout == 'function' && document.querySelector('#amscheckout-onepage')) { amastyCompleteCheckoutOriginal = cloneFunction(completeCheckout); + try { var ele; ele = document.createElement('div'); ele.id = 'co-payment-form-update'; var pEle = document.querySelector('#amscheckout-main > div.amscheckout > div > div.second-column > div:nth-child(3) > div.payment-method'); pEle.insertBefore(ele, pEle.childNodes[2]); } catch (e) { } try { document.querySelector('#payment-buttons-container').remove(); } catch (e) { }
+
I separated it because it loaded funky on one occasion and i didnt want to risk breaking the rest
— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.
@slogsdon As this isnt really a backwards compatibility change should this be version 1.2.92 or do we want to go with 1.3.0
@slogsdon OK round 2
@slogsdon
@slogsdon OK i think we are clear
If you're worried about breakage, wrap it in an if statement like I suggested in another comment.
On Thu, Nov 3, 2016 at 7:57 AM -0400, "Charlie Simmons" notifications@github.com wrote:
@ttnnkkrr commented on this pull request.
In js/securesubmit/checkout-form.js:
I separated it because it loaded funky on one occasion and i didnt want to risk breaking the rest
— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.