Missing/incorrect exception error codes

hps / heartland-php

Heartland Payment Systems Payment Gateway PHP SDK

https://developer.heartlandpaymentsystems.com/SecureSubmit/

GNU General Public License v2.0

25 stars 23 forks source link

Missing/incorrect exception error codes #14

Closed dgerrells closed 6 years ago

dgerrells commented 8 years ago

In HpsGatewayResponseValidation.php there are references to exception enums that do not exist. This makes it difficult to catch exceptions.

slogsdon commented 8 years ago

Hi @dgerrells! Thanks for the report. Which enums are missing? Looking over the code again briefly, I'm seeing all of the exception codes used in HpsGatewayResponseValidation in HpsExceptionCodes.

dgerrells commented 8 years ago

@slogsdon UNEXPECTED_GATEWAY_ERROR and GATEWAY_ERROR

slogsdon commented 8 years ago

It looks like there might have been a couple of typos. I'll get this fixed up.

slogsdon commented 6 years ago

Apologies for not circling back here. We ended up pushing an update to correct this (see 3389ba17245542ed29137a306fa352776ad7fab9).