Scalar type hints are available only in PHP 7

hps / heartland-php

Heartland Payment Systems Payment Gateway PHP SDK

https://developer.heartlandpaymentsystems.com/SecureSubmit/

GNU General Public License v2.0

25 stars 23 forks source link

Scalar type hints are available only in PHP 7 #20

Closed yohithvishnu closed 8 years ago

yohithvishnu commented 8 years ago

Files: /src/Abstractions/HpsConfigInterface.php /src/Services/HpsServicesConfig.php /src/Services/HpsCentinelConfig.php

public function setServiceUri(string $value);

Consider changing this as many of the merchants still use PHP 5.x

slogsdon commented 8 years ago

Nice catch, @yohithvishnu! I'm not sure how that snuck in there :) I'll have it removed.

yohithvishnu commented 8 years ago

I suspect this was one of the reasons why the recent release of PHP library is not working. But there seems to be other issues. Please check my other issue.

slogsdon commented 8 years ago

@yohithvishnu This should be fixed as of a586cca6f15b36133380a7581b2b38bbbb921d28