Implemented Namespacing Throughout Library.

hps / heartland-php

Heartland Payment Systems Payment Gateway PHP SDK

https://developer.heartlandpaymentsystems.com/SecureSubmit/

GNU General Public License v2.0

25 stars 23 forks source link

Implemented Namespacing Throughout Library. #7

Closed whurdwfd closed 9 years ago

whurdwfd commented 9 years ago

Implimented namespacing throughout library because class names were too generic to exist without namespaces.

Most unit tests passed. Those that didn't are likely because of lack of valid API credentials.

slogsdon commented 9 years ago

Thanks for your contribution, @whurdwfd!

Sadly, we cannot merge this PR in at the moment as we still want to keep supporting PHP 5.2, and namespaces were not added until 5.3.0. If you see any other improvements that could be made, feel free to open another issue/PR.

whurdwfd commented 9 years ago

Consider renaming classes to something less generic. The class name "Validation" conflicts with the CakePHP 2.6 Validation class for example.

slogsdon commented 9 years ago

We hear you there and have renamed some of our classes in an upcoming release to remove any collisions that could exist. We are planning on shipping that release in the next couple of months.