search

hpsaturn / MultiFuncShield-Library

Arduino Multi Function Shield Library
GNU General Public License v3.0
16 stars 13 forks source link

Beeper Pin Polarity Reversed #1

Closed partsdept closed 3 years ago

partsdept commented 3 years ago

Recently purchased a KNACRO brand MultiFunctionShield from Amazon. The beeper would not turn off.

I reversed the default BEEPER_PIN state on line 78. I also negated the value parameter in the three writeBeeper(byte value) functions, as there are three #ifdef, one for Leonardo, one for Uno, and one for Mega.

After that, everything worked ok.

hpsaturn commented 3 years ago

Thanks for report it, but I don't know what do, because in my MFS model works fine. Maybe if more users report this issue, maybe we need change it

partsdept commented 3 years ago

Hello Antonio,

I believe it might be a problem with the manufacturer. Maybe they used the wrong transistor between the pin and the beeper? My friend bought the same board and had the same problem.

https://www.amazon.com/KNACRO-Arduino-Multi-Function-Digital-Display/product-reviews/B01J9FDPVW/ref=cm_cr_dp_d_show_all_btm?ie=UTF8&reviewerType=all_reviews

There are some other Amazon customers that have the same problem. I left feedback on the Amazon page as well.

Thank you for hosting the library on GitHub.

John

On Thu, May 13, 2021 at 11:52 PM Antonio Vanegas @.***> wrote:

Thanks for report it, but I don't know what do, because in my MFS model works fine. Maybe if more users report this issue, maybe we need change it

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/hpsaturn/MultiFuncShield-Library/issues/1#issuecomment-841051523, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA7S4VENBD7ZCI23TQ6LCXDTNTCELANCNFSM4432BOAA .

hpsaturn commented 3 years ago

Maybe you can do a pull request with a method for config that? something like that:

MFS.setBeepReversePolarity(bool enable)

and maybe submit too a example?

partsdept commented 3 years ago

Hello Antonio,

I am somewhat new to using features on GitHub on larger projects. I will look into how to do a Pull Request properly and I will submit this to help the community that has been purchasing the MFS shields with the reversed transistors.

How would you get these changes back to the company in the UK where people can still download the library directly? Are you in touch with them?

Talk soon,

John

On Fri, May 14, 2021 at 3:40 AM Antonio Vanegas @.***> wrote:

Maybe you can do a pull request with a method for config that? something like that:

MFS.setBeepReversePolarity(bool enable)

and maybe submit too a example?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/hpsaturn/MultiFuncShield-Library/issues/1#issuecomment-841164374, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA7S4VG3HEZL5YFG3H3U4ODTNT4ZXANCNFSM4432BOAA .

hpsaturn commented 3 years ago

Maybe the next guide can help you to understand how to make a pull request:

https://www.digitalocean.com/community/tutorials/how-to-create-a-pull-request-on-github

With your question, I don't understand it. Please clarify better it.

Thanks.

hpsaturn commented 3 years ago

this issue was fixed on PR #3